Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backwards compatibility mode for WebViewAssetLoader #1222

Merged
merged 3 commits into from May 6, 2021

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Apr 28, 2021

Platforms affected

Android

Motivation and Context

As we discussed on the list we might need a fallback for the new changes in #1137

With this PR you can fall back to using files instead of https://localhost with this preference:
<preference name="AndroidInsecureFileModeEnabled" value="true" />

Documentation: apache/cordova-docs#1172

Testing

Manual

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #1222 (7ff9638) into master (f9e8ce8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          21       21           
  Lines        1695     1695           
=======================================
  Hits         1220     1220           
  Misses        475      475           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e8ce8...7ff9638. Read the comment docs.

@NiklasMerz NiklasMerz added this to the 10.0.0 milestone Apr 28, 2021
@NiklasMerz NiklasMerz added this to In Progress in Release Plan - 10.1.0 via automation Apr 28, 2021
@NiklasMerz NiklasMerz marked this pull request as ready for review May 3, 2021 08:01
Release Plan - 10.1.0 automation moved this from In Progress to Reviewer approved May 3, 2021
@erisu erisu changed the title add backwards compatibility mode for WebViewAssetLoader feat: add backwards compatibility mode for WebViewAssetLoader May 3, 2021
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works fine, thanks!

@NiklasMerz NiklasMerz merged commit ff1ae21 into apache:master May 6, 2021
Release Plan - 10.1.0 automation moved this from Reviewer approved to Done May 6, 2021
@NiklasMerz NiklasMerz deleted the file branch May 6, 2021 06:18
NiklasMerz added a commit that referenced this pull request Jul 14, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
chrisekelley added a commit to Tangerine-Community/docker-tangerine-base-image that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants