Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prepare): delete splash screens if none are used #1227

Merged
merged 2 commits into from
May 6, 2021
Merged

fix(prepare): delete splash screens if none are used #1227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa37f1a
fix(prepare): delete splash screens if none are used
raphinesse May 4, 2021
af3ba45
Fix wording in comment
raphinesse May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions bin/templates/cordova/lib/prepare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,13 @@ function makeSplashCleanupMap (projectRoot, resourcesDir) {
function updateSplashes (cordovaProject, platformResourcesDir) {
var resources = cordovaProject.projectConfig.getSplashScreens('android');

// if there are "splash" elements in config.xml
// if there are no "splash" elements in config.xml
if (resources.length === 0) {
events.emit('verbose', 'This app does not have splash screens defined');
return;
// We must not return here!
// If the user defines no splash screens, the cleanup map will cause any
// existing splash screen images (e.g. the defaults that we copy into a
// new app) to be removed the app folder, which is what we want.
raphinesse marked this conversation as resolved.
Show resolved Hide resolved
}

// Build an initial resource map that deletes all existing splash screens
Expand Down