Bugfix/java checks #1228
Merged
Bugfix/java checks #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breautek
force-pushed
the
bugfix/java-checks
branch
from
3310dc7
to
e70e078
Compare
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
- Coverage 72.02% 72.00% -0.02%
==========================================
Files 21 21
Lines 1698 1697 -1
==========================================
- Hits 1223 1222 -1
Misses 475 475
Continue to review full report at Codecov.
|
breautek
force-pushed
the
bugfix/java-checks
branch
from
e70e078
to
fbd0865
Compare
breautek
force-pushed
the
bugfix/java-checks
branch
from
3f4ad25
to
6daa175
Compare
breautek
force-pushed
the
bugfix/java-checks
branch
from
6daa175
to
98cd058
Compare
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
* fix: Java version parsing if java executable prints out additional information with --version * fix: Ensure JAVA_HOME path comes first in the PATH environment * refactor: Removed redundent code in favour of keeping a change introduced from another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Fixes #1221
Fixes #1203(Addressed by #1220)Description
This addresses two flaws in Java checking.
If some Java options are present,Addressed by fix(requirements check): use regex to get java version from javac output #1220javac -versionwill print out additional lines of information. A regex is used to find thejava(c) x.x.xline for proper version checking.JAVA_HOMEis set, we would only set the path ifjavacwasn't findable, and when we do, we set the path at the end of thePATHchain. To be smarter, ifJAVA_HOMEis set, we always want to set theJAVA_HOMEbin path to the front of thePATHchain so that we can guarantee the proper java executable to be used.Testing
Added new test for the
javac -versionissue. All existing tests passes. Manual testing for theJAVA_HOMEissue.Checklist
(platform)if this change only applies to one platform (e.g.(android))