feat!: drop abandoned com.github.dcendents:android-maven-gradle-plugin #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
=======================================
Coverage 71.08% 71.08%
=======================================
Files 22 22
Lines 1705 1705
=======================================
Hits 1212 1212
Misses 493 493 Continue to review full report at Codecov.
|
erisu
force-pushed
the
feat/drop-abandon-maven-plugin
branch
2 times, most recently
from
a9b4e8e
to
4ac2a2d
Compare
jcesarmobile
requested changes
Jul 2, 2021
There was a problem hiding this comment.
added a few comments, most of them related to putting mavenCentral on top of google as mavenCentral has had problems in the past finding google packages, so I think having google on top is preferred.
And the other one is about a typo.
I don't really have much experience publishing to maven, so not sure if the changes are ok.
erisu
force-pushed
the
feat/drop-abandon-maven-plugin
branch
from
4ac2a2d
to
8fbf9d3
Compare
1 task
jcesarmobile
approved these changes
Jul 2, 2021
erisu
force-pushed
the
feat/drop-abandon-maven-plugin
branch
from
c4c3be3
to
050e3a3
Compare
PieterVanPoyer
approved these changes
Jul 5, 2021
erisu
force-pushed
the
feat/drop-abandon-maven-plugin
branch
from
04c1a45
to
fa23fef
Compare
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
apache#1252) * feat: use maven-publish plugin (mavenCentral) * fix: Apache License url * fix: framework build failure without useAndroidX * fix: add aar build artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context & Description
.github.dcendents:android-maven-gradle-pluginwhich has been abandonded because maven-publish-plugin is supported by the Android Gradle Plugin 3.6.0 and highergradle buildfailure due to missinguseAndroidXflag. The build is needed to create anaarrelease artifact that is bundled with the publish.This PR requires #1251 to be merged in first.
You can see commit: 2338bc6
If you want to see only the changes of this PR.
Testing
npm tChecklist