Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow webkit version override #1254

Merged
merged 1 commit into from Jul 6, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 6, 2021

Motivation, Context & Description

Allow androidx.webkit version overrides.

Forked of #1253. Requires parent PR merged in first.

Testing

  • npm t
  • build
  • changing of versions

Checklist

  • I've run the tests to see all new and existing tests pass
  • I've updated the documentation if necessary

@erisu erisu changed the title Feat/allow webkit version override feat: allow webkit version override Jul 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1254 (eb50733) into master (e8cbeaa) will not change coverage.
The diff coverage is n/a.

❗ Current head eb50733 differs from pull request most recent head b61bc32. Consider uploading reports for the commit b61bc32 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1254   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          21       21           
  Lines        1653     1653           
=======================================
  Hits         1184     1184           
  Misses        469      469           
Impacted Files Coverage Δ
bin/templates/cordova/lib/prepare.js 44.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cbeaa...b61bc32. Read the comment docs.

@erisu erisu mentioned this pull request Jul 6, 2021
1 task
@erisu
Copy link
Member Author

erisu commented Jul 6, 2021

If there no review, I will merge within 12 hours.

@erisu erisu force-pushed the feat/allow-webkit-version-override branch from 574d090 to eb50733 Compare July 6, 2021 13:42
@erisu erisu force-pushed the feat/allow-webkit-version-override branch from eb50733 to b61bc32 Compare July 6, 2021 13:43
@erisu erisu merged commit 21f6480 into apache:master Jul 6, 2021
@erisu erisu deleted the feat/allow-webkit-version-override branch July 6, 2021 14:39
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants