Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump kotlin@1.5.20 #1256

Merged
merged 2 commits into from Jul 7, 2021
Merged

feat: bump kotlin@1.5.20 #1256

merged 2 commits into from Jul 7, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 6, 2021

Motivation, Context & Description

Bump Kotlin to 1.5.10. Using the new centralized configuration defaults.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1256 (e13b1b2) into master (69b24db) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   71.08%   71.62%   +0.54%     
==========================================
  Files          22       21       -1     
  Lines        1705     1653      -52     
==========================================
- Hits         1212     1184      -28     
+ Misses        493      469      -24     
Impacted Files Coverage Δ
bin/templates/cordova/lib/run.js 96.55% <0.00%> (-1.01%) ⬇️
bin/lib/create.js 94.59% <0.00%> (-0.31%) ⬇️
...n/templates/cordova/lib/builders/ProjectBuilder.js 73.54% <0.00%> (-0.31%) ⬇️
bin/templates/cordova/lib/prepare.js 44.75% <0.00%> (ø)
bin/templates/cordova/loggingHelper.js
bin/templates/cordova/lib/check_reqs.js 71.42% <0.00%> (+0.09%) ⬆️
bin/templates/cordova/lib/build.js 39.39% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b24db...e13b1b2. Read the comment docs.

@erisu
Copy link
Member Author

erisu commented Jul 6, 2021

If there no review, I will merge within 12 hours.

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@erisu erisu changed the title feat: bump kotlin@1.5.10 feat: bump kotlin@1.5.20 Jul 6, 2021
@erisu erisu merged commit 180a1a3 into apache:master Jul 7, 2021
@erisu erisu deleted the feat/bump-kotlin branch July 7, 2021 01:55
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
* feat: bump kotlin@1.5.10
* fix: kotlin@1.5.20 (applied suggestion)

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants