Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing super.onRequestPermissionsResult error (MissingSuperCall) #1264

Merged
merged 1 commit into from Jul 7, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 7, 2021

Motivation, Context & Description

Fix missing super call error for the onRequestPermissionsResult override.

Testing

  • npm t
  • cordova build android

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Jul 7, 2021
@erisu erisu added this to the 10.0.0 milestone Jul 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #1264 (895d03a) into master (422ce4f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          21       21           
  Lines        1653     1653           
=======================================
  Hits         1184     1184           
  Misses        469      469           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422ce4f...895d03a. Read the comment docs.

@erisu erisu merged commit b31e024 into apache:master Jul 7, 2021
@erisu erisu deleted the fix/missing-super-call branch July 7, 2021 10:57
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants