refactor: do not infer project root from script location #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
dirname-neq-project
branch
from
ba1cf91
to
3b92ea6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 71.15% 73.30% +2.14%
==========================================
Files 21 21
Lines 1650 1648 -2
==========================================
+ Hits 1174 1208 +34
+ Misses 476 440 -36
Continue to review full report at Codecov.
|
raphinesse
force-pushed
the
dirname-neq-project
branch
from
3b92ea6
to
aad74f3
Compare
- Renames the file with the only existing E2E test - Makes existing test use the API instance returned by `Api.createPlatform` - Adds another test that ensures we can still require the API from `platformProjectPath/cordova/Api.js`
raphinesse
force-pushed
the
dirname-neq-project
branch
from
aad74f3
to
0f33ee5
Compare
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
* fix(Api): do not infer project root from script location * fix(builders): do not infer project root from script location * fix(target): do not infer project root from script location * test(e2e): cleanup and extend E2E tests - Renames the file with the only existing E2E test - Makes existing test use the API instance returned by `Api.createPlatform` - Adds another test that ensures we can still require the API from `platformProjectPath/cordova/Api.js` * fix(check_reqs): do not infer project root from script location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The goal of this PR is to eliminate all areas where our JS library expects to be located inside the project directory.
This is to prepare for a change that will keep the library in node_modules and not copy it to the platform project.
Description
Basically this passes the project root that has been passed to
Apito all places that need it but do not yet have it.This also extends the E2E tests to check that we do not have to require the Api from the platform project folder.
Testing