Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build cordova.js during npm prepare #1271

Merged
merged 1 commit into from Jul 14, 2021

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

This will build cordova.js from source using npm's prepare hook.

Description

  • build cordova.js from source using npm's prepare hook
  • copy prepared cordova.js before running Java tests
  • delete and ignore the two prebuilt cordova.js files we had
  • do not bundle cordova-js-src anymore, since support for browserify builds has been discontinued for a while now

Testing

  • successfully built tarball using npm pack
  • successfully ran npm cit from clean repo
  • the generated cordova.js is identical to the previously bundled one (sans a few comments)

TODO

  • use cordova-js@6.1 once it is published

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #1271 (bafb62a) into master (adc380c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   73.26%   73.25%   -0.02%     
==========================================
  Files          21       21              
  Lines        1646     1645       -1     
==========================================
- Hits         1206     1205       -1     
  Misses        440      440              
Impacted Files Coverage Δ
lib/create.js 94.44% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc380c...bafb62a. Read the comment docs.

@raphinesse raphinesse marked this pull request as ready for review July 14, 2021 07:41
@raphinesse raphinesse merged commit 35f0d07 into apache:master Jul 14, 2021
@raphinesse raphinesse deleted the use-new-cordova-js-build branch July 14, 2021 08:25
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants