Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old VERSION file #1273

Merged
merged 1 commit into from Jul 14, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 14, 2021

Motivation, Context & Description

VERSION file is no longer referenced and should no longer be used.
Version is stored and should be read from package.json

This PR removes the VERSION file.

Testing

  • npm t
  • Various Cordova CLI commands.

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1273 (7893b39) into master (3e870e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1273   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1206     1206           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e870e3...7893b39. Read the comment docs.

@NiklasMerz NiklasMerz added this to the 10.0.0 milestone Jul 14, 2021
@erisu erisu merged commit 7da531c into apache:master Jul 14, 2021
@erisu erisu deleted the chore/remove-old-version-file branch July 14, 2021 06:34
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants