Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove forced default gradle.daemon setting #1276

Merged
merged 1 commit into from Jul 14, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 14, 2021

Motivation, Context & Description

  • Remove the forced default org.gradle.daemon setting.
  • Per Gradle Docs:

The Gradle Daemon is enabled by default, and we recommend always enabling it. You can disable the long-lived Gradle daemon via the --no-daemon command-line option, or by adding org.gradle.daemon=false to your gradle.properties file.

Since the Gradle Daemon is enabled by default, this default setting value is no longer needed.

Additional Notes

Changes were cherry-picked from #983.

This PR is based on the users master branch and is out-dated. To avoid rebasing his PR, I decided to create a new PR.

closes: #983
fixes: #982

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Jul 14, 2021
@erisu erisu added this to the 10.0.0 milestone Jul 14, 2021
@erisu erisu requested a review from NiklasMerz July 14, 2021 07:57
@erisu erisu added this to In Progress in Release Plan - 10.1.0 via automation Jul 14, 2021
@erisu erisu requested a review from dpogue July 14, 2021 07:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1276 (cd0d315) into master (adc380c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1276   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1206     1206           
  Misses        440      440           
Impacted Files Coverage Δ
lib/config/GradlePropertiesParser.js 86.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc380c...cd0d315. Read the comment docs.

Release Plan - 10.1.0 automation moved this from In Progress to Reviewer approved Jul 14, 2021
@erisu erisu merged commit b94409f into apache:master Jul 14, 2021
Release Plan - 10.1.0 automation moved this from Reviewer approved to Done Jul 14, 2021
@erisu erisu deleted the fix/remove-default-gradle-daemon-setting branch July 14, 2021 08:22
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Co-authored-by: Fernando Serboncini <fserb@fserb.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

gradle.daemon always overwritten on gradle.properties
4 participants