Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop node 10 support #1278

Merged
merged 1 commit into from Jul 15, 2021
Merged

chore!: drop node 10 support #1278

merged 1 commit into from Jul 15, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 15, 2021

Motivation, Context & Description

  • Drop Node 10 Support from GH Actions Workflow
  • Bump required Node engine to >= 12.0.0

Node 10 has been deprecated and no longer supported by the nodejs team.

Other packages has dropped node 10 and require node 12 and up.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I've updated the documentation if necessary

@erisu erisu requested a review from dpogue July 15, 2021 03:22
@erisu erisu added this to In Progress in Release Plan - 10.1.0 via automation Jul 15, 2021
@erisu erisu added this to the 10.0.0 milestone Jul 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #1278 (622c066) into master (bedb442) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1278   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          21       21           
  Lines        1645     1645           
=======================================
  Hits         1205     1205           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedb442...622c066. Read the comment docs.

Release Plan - 10.1.0 automation moved this from In Progress to Reviewer approved Jul 15, 2021
@erisu erisu merged commit 636136c into apache:master Jul 15, 2021
Release Plan - 10.1.0 automation moved this from Reviewer approved to Done Jul 15, 2021
@erisu erisu deleted the chore/node-support branch July 15, 2021 03:32
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants