Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Google Services Gradle Plugin version check failure #1287

Merged
merged 1 commit into from Jul 20, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 20, 2021

Motivation and Context

fixes: #1284

Build failure when Google Services Gradle Plugin is enabled. It fails because the version checking is calling a variable that was refactored and forgotten.

Description

Changed old variable name gradlePluginGoogleServicesVersion to new variable name cordovaConfig.GRADLE_PLUGIN_GOOGLE_SERVICES_VERSION

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Jul 20, 2021
@erisu erisu added this to the 10.0.1 milestone Jul 20, 2021
@erisu erisu requested review from dpogue and breautek July 20, 2021 05:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #1287 (6d39d63) into master (6081cc7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1287   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          21       21           
  Lines        1645     1645           
=======================================
  Hits         1205     1205           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6081cc7...6d39d63. Read the comment docs.

@pataar
Copy link

pataar commented Jul 20, 2021

After applying this fix, I'm still getting errors related to the google-services plugin.

image

edit: Bumping to com.google.gms:google-services:4.3.8 worked

@erisu
Copy link
Member Author

erisu commented Jul 20, 2021

@pataar

The error your reporting has nothing to do with the version that is set as default nor the flag is being fixed in this PR.

A plugin that your using appears to require a different version and causing your issues. You should review the plugin requirements and set the version based off what the plugin is requesting.

When I tested the changes from this PR, the Google Services Gradle plugin classpaths is checked out successfuly and builds successfully.

@erisu erisu merged commit 0ce6624 into apache:master Jul 20, 2021
@erisu erisu deleted the fix/google-services-gradle branch July 20, 2021 08:49
@pataar
Copy link

pataar commented Jul 20, 2021

@erisu Yes, upgrading the plugin worked.
Made an issue here: havesource/cordova-plugin-push#108

@erisu erisu added this to Done in Release Plan - 10.1.0 Jul 27, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Unknown property gradlePluginGoogleServicesVersion
3 participants