Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatic latest build tools finding #1294

Merged
merged 1 commit into from Jul 26, 2021

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Currently, android will attempt to pull in the latest build tools version available on the system, regardless of major versions.
This is problematic because we test against a specific major, and future majors may have breaking changes resulting in an inconsistent build.

Description

doFindLatestInstalledBuildTools will now limit it's scope to the minimum version major. This means that if our minimum required version is 30.0.3, it will filter everything that is >= 31.0.0.

Likewise, in the future when we support v31, if our minimum version was 31.0.0, it will filter everything >= 32.0.0, etc.

Testing

Ran npm test successfully.

Manually tested with:

  • build tools v31 installed, 30.0.3 uninstalled, 30.0.2 installed, errors as expected (minimum version is 30.0.3)
  • build tools v31 installed, 30.0.3 installed, 30.0.2 installed, rans successfully, using build tools version 30.0.3.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added the bug label Jul 26, 2021
@breautek breautek added this to the 10.0.1 milestone Jul 26, 2021
@breautek breautek requested a review from erisu July 26, 2021 16:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #1294 (a79e834) into master (38ca895) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1294   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          21       21           
  Lines        1645     1645           
=======================================
  Hits         1205     1205           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ca895...a79e834. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants