fix: automatic latest build tools finding #1294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Currently, android will attempt to pull in the latest build tools version available on the system, regardless of major versions.
This is problematic because we test against a specific major, and future majors may have breaking changes resulting in an inconsistent build.
Description
doFindLatestInstalledBuildTools
will now limit it's scope to the minimum version major. This means that if our minimum required version is30.0.3
, it will filter everything that is>= 31.0.0
.Likewise, in the future when we support v31, if our minimum version was
31.0.0
, it will filter everything>= 32.0.0
, etc.Testing
Ran npm test successfully.
Manually tested with:
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)