New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Added support for BoM imports #1311
Conversation
https://docs.gradle.org/current/userguide/platforms.html#sub:bom_import Changes * propertiesObj.systemLibs regex - exclude the value contains ( * added propertiesObj.bomPlatforms - any value which matches platform("...")
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 73.25% 73.00% -0.25%
==========================================
Files 21 21
Lines 1645 1652 +7
==========================================
+ Hits 1205 1206 +1
- Misses 440 446 +6
Continue to review full report at Codecov.
|
@breautek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
But please be patient on an actual merge -- Not sure if there will be another minor release or not for 10.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey
Is it possible to add some info about how to use this in a plugin?
Maybe some sample configuration/code from your plugin could clarify this a little bit?
Kind regards
Pieter
@PieterVanPoyer No problems Below is the key snippet that this PR would enable
I've attached an example plugin.xml which enables firebase dependencies using BoM |
We have 2 green checks and master is in 11.x dev state so merging! Thank you @ebhsgit for your contribution and effort into preparing this PR. |
Platforms affected
Android
Motivation and Context
Bill of Material (BoM) pattern simplifies the management of dependency versions (when there are multiple packages with shared dependencies).
https://docs.gradle.org/current/userguide/platforms.html#sub:bom_import
A cordova plugin may want to use BoM to manage the versions of it's dependencies.
Currently there is no way to implement this:
Example using Firebase BoM
https://firebase.google.com/docs/android/learn-more#bom
Description
propertiesObj.systemLibs
regex - exclude any imports that contains(
in it's package namepropertiesObj.bomPlatforms
- any value package which matchesplatform("...")
Testing
I was able to compile my project (with custom plugin) which uses Firebase BoM
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)