fix(AllowListPlugin): Safely handle default allow navigation policy in allow request

[jskrepnek]

Motivation and Context

fixes: #1322

Description

shouldAllowRequest will throw an exception for all URLS that are not in the navigation allowed list. This change safely tests the result of shouldAllowNavigation, avoiding the exception and allowing for the execution to continue to see if the URL is in the request allowed list.

Testing

Incorporating this change into our project successfully allows expected network requests that previously were allowed with the whitelist plugin.

Checklist

• I've run the tests to see all new and existing tests pass
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

[jskrepnek]

@erisu I'm a bit confused as to why shouldAllowRequest calls shouldAllowNavigation in the first place.

My basic expectation is that shouldAllowNavigation would map to allow-navigation tags and shouldAllowRequest would map to access tags.

Haven't looked deeply, just wanted to confirm it was intended and curious why.

[erisu]

I would have to take a look at the code to try and figure it out myself.

I didnt write the original code. All I did was integrate the whitelist plugin as a core feature of the Cordova Android platform and renamed it to AllowList.

[jskrepnek]

I would have to take a look at the code to try and figure it out myself.

I didnt write the original code. All I did was integrate the whitelist plugin as a core feature of the Cordova Android platform and renamed it to AllowList.

Ah, okay. It looks like a bit of refactoring led to the bug. This is the original code:

    @Override
    public Boolean shouldAllowRequest(String url) {
        if (Boolean.TRUE == shouldAllowNavigation(url)) {
            return true;
        }
        if (allowedRequests.isUrlWhiteListed(url)) {
            return true;
        }
        return null; // Default policy
    }

[erisu]

Ah yes, nice catch.

That refactoing bug would probally have been my fault :D Sorry

Changes looks correct.