Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PluginManager): AllowNavigation default policy to handle scheme & hostname #1349

Merged
merged 1 commit into from Sep 13, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 13, 2021

Motivation and Context

Allow Navigation should also handle the default policy for scheme & hostname

Testing

  • npm t
  • cordova build
  • cordova run

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu requested a review from dpogue September 13, 2021 06:12
@erisu erisu added the bug label Sep 13, 2021
@erisu erisu added this to the 10.1.1 milestone Sep 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #1349 (832ed7c) into master (aea6b7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files          21       21           
  Lines        1643     1643           
=======================================
  Hits         1202     1202           
  Misses        441      441           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea6b7f...832ed7c. Read the comment docs.

@erisu erisu merged commit ca19084 into apache:master Sep 13, 2021
@erisu erisu deleted the fix/allow-navigation-default-policy branch September 13, 2021 06:48
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants