Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GH-1391): Reword minimum build tools version error message #1401

Merged
merged 1 commit into from Feb 22, 2022

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Solves confusion as the current error message suggest they can install any newer version when that is often not the case.
Fixes #1391

Description

Removes text such as "or higher" / "or later" which suggest that the user can install any version later. Instead of attempting to explain that they need a specific major version, I reworded the text to suggest/recommend installing the default build tools version in which Cordova is tested against. Advanced users can still install alternate versions if they know what they are doing and the risks involved.

Testing

Ran npm test and manually tested by uninstalling build tools and trying to build.
Note: npm test will fail due to the lack of build tools version installed.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #1401 (66e1b4d) into master (f100809) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1401   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1205     1205           
  Misses        441      441           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f100809...66e1b4d. Read the comment docs.

@breautek breautek merged commit 6d3ce21 into apache:master Feb 22, 2022
@breautek breautek deleted the fix/GH-1391/min-tools-error branch February 22, 2022 14:14
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error message when installed build tools version greater than MIN_BUILD_TOOLS_VERSION + 1
3 participants