fix: detect JAVA_HOME with Java 11

[ltm]

Platforms affected

Linux and Windows

Motivation and Context

Starting with Java 9 the JRE and JDK no longer include tools.jar as described in JEP 220. As a result the check_java function is unable to detect a Java 11 installation unless the JAVA_HOME environment variable is set manually:

cordova-android/lib/env/java.js

Lines 101 to 102 in 6d3ce21

	var maybeJavaHome = path.dirname(path.dirname(javacPath));
	if (fs.existsSync(path.join(maybeJavaHome, 'lib', 'tools.jar'))) {

The check for tools.jar appears to have been added in commit 7133576.

Description

This change instead checks for the presence of ${maybeJavaHome}/bin/java or ${maybeJavaHome}/bin/java.exe. This is similar to the checks performed by gradlew and gradlew.bat.

Testing

On Debian 11:

$ readlink -f $(which javac)
/usr/lib/jvm/java-11-openjdk-amd64/bin/javac
$ ls /usr/lib/jvm/java-11-openjdk-amd64/lib/tools.jar
ls: cannot access '/usr/lib/jvm/java-11-openjdk-amd64/lib/tools.jar': No such file or directory
$ ls /usr/lib/jvm/java-11-openjdk-amd64/bin/java
/usr/lib/jvm/java-11-openjdk-amd64/bin/java

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[codecov-commenter]

Codecov Report

Merging #1406 (c794ee5) into master (6d3ce21) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
- Coverage   73.20%   73.14%   -0.07%     
==========================================
  Files          21       21              
  Lines        1646     1646              
==========================================
- Hits         1205     1204       -1     
- Misses        441      442       +1     

Impacted Files	Coverage Δ
lib/env/java.js	98.00% <100.00%> (ø)
lib/check_reqs.js	69.62% <0.00%> (-0.75%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3ce21...c794ee5. Read the comment docs.

[erisu]

LGTM

[breautek]

Looks good, thanks for the well documented PR and fix!