Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Drop Node 12 support #1411

Merged
merged 1 commit into from Apr 17, 2022
Merged

chore!: Drop Node 12 support #1411

merged 1 commit into from Apr 17, 2022

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Apr 4, 2022

Platforms affected

Android

Motivation and Context

Node LTS Support is coming to an end April 2022. So it's a good time to drop support for Node 12 for our next major release.

Description

Removed Node 12 from our test matrix, and upgraded our package Node engines.

Testing

Ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 11.0.0 milestone Apr 4, 2022
@breautek breautek added this to To Do in Release Plan - 11.0.0 via automation Apr 4, 2022
Release Plan - 11.0.0 automation moved this from To Do to In Progress Apr 5, 2022
@erisu erisu changed the title chore(breaking): Drop Node 12 support chore!: Drop Node 12 support Apr 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #1411 (bfd26ca) into master (6d3ce21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1411   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1205     1205           
  Misses        441      441           
Impacted Files Coverage Δ
lib/env/java.js 98.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3ce21...bfd26ca. Read the comment docs.

@erisu erisu merged commit adcd9d9 into apache:master Apr 17, 2022
Release Plan - 11.0.0 automation moved this from In Progress to Done Apr 17, 2022
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants