Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): bump @cordova/eslint-config@^4.0.0 #1421

Merged
merged 3 commits into from Apr 18, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 17, 2022

Motivation and Context

use latest linting tools.

Description

  • updated @cordova/eslint-config@^4.0.0
  • applied auto lint corrections
  • apply manual changes to the hasAndroidHome variable.
    • convert var to let
    • hoisted the variable to the top of the function.

Testing

  • npm t
  • created project & added platform
  • built platform
  • ran application

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 11.0.0 milestone Apr 17, 2022
@erisu erisu added this to To Do in Release Plan - 11.0.0 via automation Apr 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #1421 (c5d46fd) into master (62ed71c) will not change coverage.
The diff coverage is 76.52%.

@@           Coverage Diff           @@
##           master    #1421   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1205     1205           
  Misses        441      441           
Impacted Files Coverage Δ
lib/build.js 40.59% <40.90%> (ø)
lib/prepare.js 44.61% <47.45%> (ø)
lib/check_reqs.js 70.37% <55.55%> (ø)
lib/AndroidProject.js 61.11% <61.29%> (ø)
lib/Api.js 50.61% <64.28%> (ø)
lib/builders/ProjectBuilder.js 73.24% <92.50%> (ø)
lib/create.js 94.24% <97.56%> (ø)
lib/Adb.js 100.00% <100.00%> (ø)
lib/AndroidManifest.js 100.00% <100.00%> (ø)
lib/android_sdk.js 96.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ed71c...c5d46fd. Read the comment docs.

Release Plan - 11.0.0 automation moved this from To Do to In Progress Apr 17, 2022
@erisu erisu merged commit a2bb7f1 into apache:master Apr 18, 2022
Release Plan - 11.0.0 automation moved this from In Progress to Done Apr 18, 2022
@erisu erisu deleted the chore/bump-eslint-for-11.0.0 branch April 18, 2022 01:39
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
* chore(npm): bump @cordova/eslint-config@^4.0.0
* style(lint): apply auto corrections
* style(lint): convert hasAndroidHome var to let and hoisted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants