Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore checkReqs in prepare.js #1434

Merged
merged 1 commit into from May 18, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented May 18, 2022

Motivation and Context

Restore checkReqs in prepare.js

Description

In PR #1431, additional usage of checkReqs was added to prepare.js.
In PR #1154, the only usage of checkReqs was removed so the requirement was deleted.

Because of #1154 was merged first and #1431 was merged second, with no conflict, the test ended up failing on master.

This PR just adds back the require statement.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added the bug label May 18, 2022
@erisu erisu requested a review from breautek May 18, 2022 15:21
@erisu erisu added this to the 11.0.0 milestone May 18, 2022
@erisu erisu added this to To Do in Release Plan - 11.0.0 via automation May 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1434 (83b1163) into master (bd0c8ce) will increase coverage by 3.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   72.95%   75.96%   +3.01%     
==========================================
  Files          21       21              
  Lines        1653     1677      +24     
==========================================
+ Hits         1206     1274      +68     
+ Misses        447      403      -44     
Impacted Files Coverage Δ
lib/check_reqs.js 71.05% <76.47%> (+0.68%) ⬆️
lib/create.js 94.32% <100.00%> (+0.08%) ⬆️
lib/prepare.js 60.00% <100.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4744bfe...83b1163. Read the comment docs.

@erisu erisu merged commit 53d39fb into apache:master May 18, 2022
Release Plan - 11.0.0 automation moved this from To Do to Done May 18, 2022
@erisu erisu deleted the fix/add-back-checkReqs branch May 18, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants