Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: set & use ANDROID_HOME as default #1444

Merged
merged 8 commits into from Jun 27, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 27, 2022

Motivation and Context

Resolves #1425

Description

  • Check ANDROID_HOME before ANDROID_SDK_ROOT
  • Set ANDROID_HOME based on paths
  • Flag ANDROID_SDK_ROOT as deprecate

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from breautek June 27, 2022 06:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #1444 (9383e82) into master (4916e1d) will not change coverage.
The diff coverage is 78.57%.

❗ Current head 9383e82 differs from pull request most recent head 8510c2b. Consider uploading reports for the commit 8510c2b to get more accurate results

@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files          21       21           
  Lines        1677     1677           
=======================================
  Hits         1274     1274           
  Misses        403      403           
Impacted Files Coverage Δ
lib/check_reqs.js 71.05% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4916e1d...8510c2b. Read the comment docs.

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erisu erisu merged commit bf9e4d8 into apache:master Jun 27, 2022
@erisu erisu deleted the fix/use-android-home branch June 27, 2022 13:07
@erisu erisu added this to To Do in Release Plan - 11.0.0 via automation Jun 27, 2022
@erisu erisu added this to the 11.0.0 milestone Jun 27, 2022
@jcesarmobile jcesarmobile moved this from To Do to In Progress in Release Plan - 11.0.0 Jun 28, 2022
@jcesarmobile jcesarmobile moved this from In Progress to Done in Release Plan - 11.0.0 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

ANDROID_HOME is un-deprecated, and ANDROID_SDK_ROOT is now deprecated
3 participants