Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept file cookies only if AndroidInsecureFileModeEnabled #1449

Merged
merged 1 commit into from Jun 29, 2022

Conversation

jcesarmobile
Copy link
Member

Platforms affected

android

Motivation and Context

we are enabling file cookies even if AndroidInsecureFileModeEnabled is not enabled

Description

accept file cookies only if AndroidInsecureFileModeEnabled is true
also suppress the warning caused by using that method

removes two unused imports
closes #1080

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

@erisu erisu merged commit 2d2ad4c into master Jun 29, 2022
@erisu erisu deleted the file-cookies branch June 29, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security issue with setAcceptFileSchemeCookies
2 participants