Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: display warning on deprecated <splash> tag usage #1451

Merged
merged 2 commits into from Jun 30, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 30, 2022

Motivation and Context

Users may still use old tag.

Description

Display a warning to migate to the new preference tag when <splash> tag is used.

This only checks for slash tags in platform[name="android as global tags could still be used in other platforms.

Testing

cordova build

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1451 (f68faa7) into master (606e9c4) will decrease coverage by 0.10%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   72.52%   72.41%   -0.11%     
==========================================
  Files          21       21              
  Lines        1740     1744       +4     
==========================================
+ Hits         1262     1263       +1     
- Misses        478      481       +3     
Impacted Files Coverage Δ
lib/prepare.js 47.10% <25.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606e9c4...f68faa7. Read the comment docs.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

Looks like I get these warnings twice but I think this is ok

grafik

@erisu erisu merged commit 273d1bd into apache:master Jun 30, 2022
@erisu erisu deleted the chore/warn-for-deprecated-tag branch June 30, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants