Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: bump jasmine@4.2.1 w/ package-lock rebuild #1452

Merged
merged 1 commit into from Jun 30, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 30, 2022

Motivation, Context & Description

Latest Jasmine Test Framework w/ rebuilt package-lock

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from NiklasMerz June 30, 2022 11:05
@erisu erisu added this to the 11.0.0 milestone Jun 30, 2022
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok if CI green

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1452 (01e30bd) into master (273d1bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1452   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files          21       21           
  Lines        1744     1744           
=======================================
  Hits         1263     1263           
  Misses        481      481           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273d1bd...01e30bd. Read the comment docs.

@erisu erisu merged commit 861fec2 into apache:master Jun 30, 2022
@erisu erisu deleted the test/update-jasmine branch June 30, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants