Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump target sdk & build tools for SDK 33 support #1538

Merged
merged 3 commits into from Mar 10, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 11, 2023

Motivation and Context

Set latest Target SDK & Build Tools Version.

Description

  • Target SDK Version 33
  • Minimum Build Tools Version 33.0.2

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 12.0.0 milestone Jan 11, 2023
@erisu erisu force-pushed the feat/android-sdk-33-support branch from b188355 to d8d9bcc Compare January 11, 2023 01:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #1538 (248893e) into master (2318ef5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          21       21           
  Lines        1751     1751           
=======================================
  Hits         1263     1263           
  Misses        488      488           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu marked this pull request as ready for review March 9, 2023 09:59
@erisu
Copy link
Member Author

erisu commented Mar 9, 2023

@jcesarmobile It seems that build tools 33.0.2 is out. Should I bump?

Or do you think it would be better to keep it as is or even lower the minimum to 33.0.0 instead?

Screen Shot 2023-03-09 at 19 12 54

@jcesarmobile
Copy link
Member

Probably

@erisu
Copy link
Member Author

erisu commented Mar 9, 2023

Probably

Which one you recommend?

-> 33.0.0
-> 33.0.1
-> 33.0.2?

@jcesarmobile
Copy link
Member

I don’t know, since it’s the minimum allowed maybe 33.0.0, but both 33.0.0 and 33.0.1 present bugs that were fixed in 33.0.2, so not sure if we should require 33.0.2 as minimum

@breautek
Copy link
Contributor

breautek commented Mar 9, 2023

We generally discourage people from updating the build tools version unless absolutely necessary/know what they are doing so we probably should use the latest patch available, so that cordova by default will use the latest patch available (at the time of this PR) obviously.

33.0.1 resolves a compilation issue:

AIDL fails with build-tools 33.0.0. (See issue #236167971)

It probably doesn't affect the cordova base but could affect other native libraries or third-party plugins.

33.0.2 addresses what appears to be a minor issue:

core-lambda-stubs.jar version 33.0.0 differs on macOS versus Linux/Windows. (See issue #237299698.)

Nonetheless, I think we should just use the latest patch available, so that on release we can cleanly write an update guide stating they must have 33.0.2 installed, etc. It may save us having to explain that they need to set a preference to upgrade build tools to address AIDL issue if that issue affects them.

Just my own opinion. If they absolutely need to use 33.0.0 for some reason, I believe they can still set the android-buildToolsVersion themselves.

@jcesarmobile
Copy link
Member

no, they can't use an older version since this value is for the minimum version allowed and the code has a check that prevents from using older versions that the one we set there

but I'm ok making the minimum the latest at the moment of the release

@erisu erisu force-pushed the feat/android-sdk-33-support branch from d8d9bcc to 248893e Compare March 10, 2023 02:54
@erisu erisu merged commit 992a60a into apache:master Mar 10, 2023
@erisu erisu deleted the feat/android-sdk-33-support branch March 10, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants