feat!: bump Gradle 7.6 & AGP 7.4.2 #1539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1539 +/- ##
==========================================
+ Coverage 72.13% 72.38% +0.25%
==========================================
Files 21 23 +2
Lines 1751 1767 +16
==========================================
+ Hits 1263 1279 +16
Misses 488 488
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Should we go with gradle 8? It’s already available and recommended by android studio Flamingo, which is still in beta but will be released in the coming months |
|
@jcesarmobile I would like to go with Gradle 8 as soon as it is out of beta. I started merging in the next major PRs. I will also be preparing and working on the tooling majors simultaneously. In the meantime, we could delay the release while working on tooling and hope Android Gradle Plugin 8's official release is done. Also, isn't there a release candidate stage? I am wondering if it will take longer than we hope. Additionally, we could just merge what we have now for testing (nightly) and then create another PR as soon as Gradle 8 is available. |
|
Gradle 8 is final, what is beta is the android studio version that recommends using gradle 8 |
|
Sorry, I am talking about Android Gradle Plugin 8.0 for Gradle 8.0 support The current released plugin does not support Gradle 8.0. The Android Gradle Plugin 8.0 is still in beta and has not reached release candidate stage. |
|
Where do you see that it’s still beta? here it says latest is 8.1 and doesn’t say anything about being beta Electric Eel requires a plugin version between 3.2-7.4 So not sure if using 8 or 8.1 will cause issues |
|
@jcesarmobile https://developer.android.com/reference/tools/gradle-api this is where I read that AGP 8 still beta and the page was last updated 3 days ago. |
|
ah, cool, then yeah, we should wait |
erisu
force-pushed
the
feat/gradle-7.x-bump
branch
from
5e2141b
to
7f53f0e
Compare
erisu
changed the title
|
Currently trying to change how handle the package name. One of the newer versions of AGP deprecated setting the package name in AndroidManifest file. There is a print out about this deprecation. The commit above is my current changes but there are still a few other areas that looks at AndroidManifest for the package name, including the testing. |
erisu
force-pushed
the
feat/gradle-7.x-bump
branch
from
e91cf2b
to
5c02cd0
Compare
|
@jcesarmobile, Android Gradle Plugin 8.0 has entered the release candidate stage. Also, If we were to upgrade to AGP 8.0 in this release, it have to force everyone up to JDK 17. AGP 8.0 requires JDK 17. Also, Android Studio Flamingo will bundle JDK 17. Flamingo is not in beta stage. It is still in the canary stage. I still dont have an exact ETA for the Android release, but must be released no later then July for Google's August requirements. I think we sometimes explain that users can and maybe should use the JDK version that is bundled with Android Studio, but I am nto sure if Flamingo will be avaialble before AGP 8.0 is released. Maybe more documentation in how to support JDK 17 + JDK 11... |
|
flamingo is RC, at least the macOS version
pretty sure they match the gradle plugin versions with the Android studio version |
|
Awesome. I guess all pages were not updated. This page still says beta. And the part where I read canary was a misunderstanding. It was when JDK 17 was bundled with Android Studio. |
erisu
force-pushed
the
feat/gradle-7.x-bump
branch
from
5c02cd0
to
1ccf09d
Compare
* fix!: remove deprecated package name from AndroidManifest * fix: package name * fix: rename CordovaGradleConfigParser's _save to write * test: fix CordovaGradleConfigParser related specs * fix: test refactoring for gradle namespace Co-authored-by: Norman Breau <norman@nbsolutions.ca>
erisu
changed the title
|
I will go ahead and open up this PR for a review and move forward with merging it in. Since this PR contians code changes for fixing things that were deprecated in the recent 7.x bump, I will recommend a second PR that focuses on AGP 8.0 and Gradle 8.0. |
|
Tested on a hello world app. |
Motivation and Context
Use latest available Gradle & Android Gradle Plugin
Description
Updated the following versions:
Gradle: 7.6
Android Gradle Plugin: 7.4.2 (Current)
Testing
n/a
Checklist