Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Bump min SDK to 24 #1571

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Commits on Mar 15, 2023

  1. feat!: Bump min SDK to 24

    Rationale:
    API 22 & API 23 both account for an insignificant part of the market share.
    While API 24 - API 26 has similar market share, we felt that bumping to API 26
    from API 22 is too large of a jump.
    
    Legacy devices may be completely out of support by Google and may not be able
    to receive the latest webview version. As of writing, Chromium's latest
    tag shows they are using a Min SDK version of 24. (Ref: https://chromium.googlesource.com/chromium/src/+/refs/tags/113.0.5653.1/build/config/android/config.gni#46)
    
    Based on AOSP emulators, API 24 (Android 7.0) will ship with
    Chrome 52 webview, which has good support for ECMAscript 2015 (ES6) (Ref: https://caniuse.com/?search=es6)
    
    While in most cases, app users will likely have a modern webview vesion installed, this means
    you can be confident that the app user will have a chrome webview version with good ES6 support,
    even if they happen to be running on a factory versioned device.
    
    See the mailing thread for the full discussion:
    https://lists.apache.org/thread/zcgof080hdzzo2j96mjz0qpj0gotmn57
    breautek committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    6ad35a0 View commit details
    Browse the repository at this point in the history