fix(GH-1432): Default content src when content tag is missing #1573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
fixes #1432
If the project is missing the
<content>
tag inside theirconfig.xml
, Cordova will completely crash with a fatal error.Description
Inside
ConfigXMLParser
, I added aonPostParse
private method in which I check to see if thecontentSrc
string is still null. If so, it can be assumed that the<content>
tag was completely missing and thecontentSrc
string is then fallen back to the default content source, which is now powered by a constant.Testing
Ran
npm test
and manually ran against a project with a missing<content>
. Observing the crash in cordova-android@11, and observing the fix using locally packed tarball install.Additionally I also tested renaming the
index.html
and setting<content src>
respectfully to confirm no breakage.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)