Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed obsolete version code checks #1588

Merged

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Apr 8, 2023

Now that our Min SDK is 24, testing for >= N (API 24) and >= M (API 22) is obsolete as it will always be true. Simplify the codebase by removing the conditions and keeping only the API 24 or later codepath.

Platforms affected

Motivation and Context

Description

Testing

Manual build + npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Now that our Min SDK is 24, testing for >= N (API 24) and >= M (API 22) is obsolete as it will always be true.
Simplify the codebase by removing the conditions and keeping only the API 24 or later codepath.
@breautek breautek added this to the 12.0.0 milestone Apr 8, 2023
@breautek breautek requested a review from erisu April 8, 2023 15:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023

Codecov Report

Merging #1588 (05c0a66) into master (d4bfd50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          21       21           
  Lines        1751     1751           
=======================================
  Hits         1263     1263           
  Misses        488      488           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breautek breautek merged commit b91639d into apache:master Apr 8, 2023
6 checks passed
@breautek breautek deleted the refactor/cleanup-obsolete-sdk-checks branch April 8, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants