Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump default kotlin to version 1.7.21 #1594

Merged
merged 1 commit into from Apr 14, 2023

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Apr 14, 2023

Platforms affected

Android / Kotlin plugins

Motivation and Context

Closes #1564

The default should be a modern version, or fairly modern version.

The chosen version is based on the Gradle Compatibility Matrix: https://docs.gradle.org/current/userguide/compatibility.html

1.7.21 is the current latest version of the 1.7 Kotlin release, based on Kotlin's Releases page.

Uses can still change the version if necessary using:

<preference name="GradlePluginKotlinVersion" value="..."/>

Why not 1.7.22?

This is a technical release. It doesn't contain any fixes that aren't included in Kotlin 1.7.21.
Version 1.7.22 of the Kotlin plugin will not be available for downloading or installing in any IDEs.

https://github.com/JetBrains/kotlin/releases/tag/v1.7.22

Description

Updated the defaults file.

Testing

Ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

The rationale is based on the Gradle Compatibility Matrix: https://docs.gradle.org/current/userguide/compatibility.html

1.7.21 is the current latest version of the 1.7 Kotlin release.
@breautek breautek added this to the 12.0.0 milestone Apr 14, 2023
@breautek breautek requested a review from erisu April 14, 2023 01:55
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #1594 (8bc53d3) into master (a9d4d4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1594   +/-   ##
=======================================
  Coverage   71.82%   71.82%           
=======================================
  Files          23       23           
  Lines        1796     1796           
=======================================
  Hits         1290     1290           
  Misses        506      506           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@breautek breautek merged commit 2252c09 into apache:master Apr 14, 2023
6 checks passed
@breautek breautek deleted the kotlin-upgrade branch April 14, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin
3 participants