deprecate: CoreAndroid.getBuildConfigValue #1597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
We have 2 copies of an implementation of
getBuildConfigValue
, one insideCoreAndroid
and another inBuildConfig
.The
BuildConfig
variant was directly migrated from our old deprecatedcordova-plugin-compat
package, so it is more likely that theBuildConfig
variant is used more than theCoreAndroid
version.Description
Added
@Deprecated
decorator for build compilation warning.Add
@deprecated
JavaDoc for code editor hints and information on how to migrate.Changed
CoreAndroid.getBuildConfigValue
to simply call and return the result ofBuildHelper.getBuildConfigValue
Note that the screenshots are from a test app that was changed to use the deprecated API in the
MainActivity
.MainActivity
template doesn't actually use the deprecated API.Testing
npm test
and manual testing.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)