Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: CoreAndroid.getBuildConfigValue #1597

Merged

Conversation

breautek
Copy link
Contributor

Platforms affected

Motivation and Context

We have 2 copies of an implementation of getBuildConfigValue, one inside CoreAndroid and another in BuildConfig.
The BuildConfig variant was directly migrated from our old deprecated cordova-plugin-compat package, so it is more likely that the BuildConfig variant is used more than the CoreAndroid version.

Description

Added @Deprecated decorator for build compilation warning.

Screenshot from 2023-04-14 09-30-16

Add @deprecated JavaDoc for code editor hints and information on how to migrate.

Screenshot from 2023-04-14 09-31-06

Screenshot from 2023-04-14 09-30-50

Changed CoreAndroid.getBuildConfigValue to simply call and return the result of BuildHelper.getBuildConfigValue

Note that the screenshots are from a test app that was changed to use the deprecated API in the MainActivity. MainActivity template doesn't actually use the deprecated API.

Testing

npm test and manual testing.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 12.0.0 milestone Apr 14, 2023
@breautek breautek requested a review from erisu April 14, 2023 12:45
@codecov-commenter
Copy link

Codecov Report

Merging #1597 (6a39057) into master (2252c09) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   71.82%   71.82%           
=======================================
  Files          23       23           
  Lines        1796     1796           
=======================================
  Hits         1290     1290           
  Misses        506      506           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@breautek breautek merged commit 5b546a2 into apache:master Apr 14, 2023
6 checks passed
@breautek breautek deleted the deprecate/coreandroid/getbuildconfig branch April 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants