Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add listTarget api #1602

Merged
merged 2 commits into from May 8, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 20, 2023

Platforms affected

n/a

Motivation and Context

Support calling for listTarget on the PlatformAPI.

Will be used by Cordova CLI/Lib 12

Description

Added listTargets on platform api and added supporting methods in the run.js file

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from dpogue April 20, 2023 13:33
@erisu erisu modified the milestones: 13.x, 12.0.0 Apr 20, 2023
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #1602 (a5ffb74) into master (7efe90f) will increase coverage by 0.34%.
The diff coverage is 44.82%.

@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   71.82%   72.17%   +0.34%     
==========================================
  Files          23       23              
  Lines        1796     1829      +33     
==========================================
+ Hits         1290     1320      +30     
- Misses        506      509       +3     
Impacted Files Coverage Δ
lib/run.js 68.96% <40.74%> (-24.59%) ⬇️
lib/Api.js 51.80% <100.00%> (+1.18%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu merged commit 7da13cc into apache:master May 8, 2023
9 checks passed
@erisu erisu deleted the feat/use-platform-api-target-list branch May 8, 2023 13:27
breautek pushed a commit to breautek/cordova-android that referenced this pull request Oct 21, 2023
* feat: add listTarget api
* test: write Platform API target list specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants