refactor: remove shelljs dependency #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
force-pushed
the
migrate-shelljs-to-fsextra
branch
from
3d9778d
to
d96074f
Compare
erisu
force-pushed
the
migrate-shelljs-to-fsextra
branch
6 times, most recently
from
04fafc4
to
60502f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 66.27% 65.94% -0.33%
==========================================
Files 19 21 +2
Lines 1853 1850 -3
==========================================
- Hits 1228 1220 -8
- Misses 625 630 +5
Continue to review full report at Codecov.
|
erisu
force-pushed
the
migrate-shelljs-to-fsextra
branch
from
60502f2
to
c327a23
Compare
erisu
force-pushed
the
migrate-shelljs-to-fsextra
branch
from
c327a23
to
afa1741
Compare
erisu
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
I added some code refactor, cleanup, and removed additional references to shelljs that was missed.
I also ran manual tests on macOS and Windows. Tests covers:
cordova platform addcordova platformcordova requirementscordova prepare androidcordova build androidcordova build android(w/ keystore)cordova run android(not tested on Windows)cordova clean androidcordova platform rm android
|
Erisu finished this for me and I've tested it on linux. npm test runs fine, and did some manual testing running |
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 5, 2020
The pattern contained an additional plus that slipped in during the refactoring done in apache#842. See [the diff][1] for details. [1]: apache@09e8248#diff-26c51bfaa44eff1e46fd61ec3225ec13L640-R650
raphinesse
added a commit
that referenced
this pull request
Oct 6, 2020
The pattern contained an additional plus that slipped in during the refactoring done in #842. See [the diff][1] for details. [1]: 09e8248#diff-26c51bfaa44eff1e46fd61ec3225ec13L640-R650
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 20, 2020
… Windows This changes the implementation to be closer to what it was before apache#842 with everything being in one place.
raphinesse
added a commit
that referenced
this pull request
Nov 19, 2020
…ows (#1102) * test(check_reqs): test default Java location detection on Windows * refactor(check_reqs): use glob for default Java location detection on Windows This changes the implementation to be closer to what it was before #842 with everything being in one place. * fix: remove always-taken if statement * feat: take both Program Files variants from env * refactor(check_reqs): cosmetic changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Replaces
shelljswith favour for nativefsAPIs, or apis fromfs-extraFixes #781
Description
All shelljs code has been removed and replaced. In some cases,
whichpackage was used as a replacement.Testing
npm testpasses. Manual testing has been done on linux by usingcordova platform add <my git fork>Windows has not been tested. Test are pending.
Mac has has also not been tested. I don't have easy access to a mac machine, so assistance here would help me.
Checklist
(platform)if this change only applies to one platform (e.g.(android))