Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Set ANDROID_HOME instead of deprecated ANDROID_SDK_ROOT #1306

Merged
merged 3 commits into from
May 23, 2023

Conversation

mosabab
Copy link
Contributor

@mosabab mosabab commented May 19, 2023

Platforms affected

Android

Motivation and Context

Closes #1296

ANDROID_HOME is default
Since this PR: apache/cordova-android#1471
The documentation should be deal with latest updates.
Because ANDROID_HOME is new default and ANDROID_SDK_ROOT is deprecated.


Also to insure that Android SDK Command-line Tools is selected.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@mosabab
Copy link
Contributor Author

mosabab commented May 20, 2023

@breautek Thanks for explain.

@mosabab mosabab requested a review from breautek May 20, 2023 17:31
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will merge in 48 hours unless someone else have further comments.

@breautek breautek merged commit 488ead6 into apache:master May 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android SDK Install Instructions - Explicitly declare which packages are needed
2 participants