Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two corrections to the "Icons" page #1339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DAnn2012
Copy link
Contributor

@DAnn2012 DAnn2012 commented Nov 4, 2023

Platforms affected

"Icons" page (iOS and Electron)

Motivation and Context

  1. The "density" parameter is for Android not for iOS
  2. The correct value is "app" not "application"

Description

  1. Removed "density" from the example
  2. Corrected from "application" to "app"

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@NiklasMerz NiklasMerz requested a review from erisu November 4, 2023 19:42
@DAnn2012
Copy link
Contributor Author

DAnn2012 commented Feb 5, 2024

Hello @NiklasMerz

When are you planning to review these changes of mine?

Thank you.

@DAnn2012
Copy link
Contributor Author

DAnn2012 commented Mar 4, 2024

Hello @erisu

When are you planning to review these changes of mine?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant