update example on buildConfig #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is it relevant to know here that |
3 tasks
|
I already answer on this topic sir, [FIX] better support to find home path . Let discussion about this. |
|
Thanks @hiepxanh for the proposal, my response is in apache/cordova-cli#359 (comment). |
|
I should close this issue, shouldn't I sir? @brodybits |
brodybits
requested changes
Nov 19, 2018
There was a problem hiding this comment.
Pending conclusion of apache/cordova-android#563 and apache/cordova#48. I think we should also finish apache/cordova-cli#359 before merging this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
There is no tutorial or any example on google or the docs. I dont event know that
~can relate toHOMEpath. It take me 5 hours to searching, and finally I have to go to source code to read and find out that can help me. I hope on small change can help people working on multi device can easy locate that home path to point to.androidfolder more easy.What testing has been done on this change?
Checklist