Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update allow list name #1032

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 26, 2020

Motivation and Context

apache/cordova#218

Description

Rename Whitelist to AllowList.

This does not rename:

  • usage in CHANGELOG.md as it is history.

Testing

  • npm t
  • cordova platform add
  • cordova build ios
  • cordova run ios

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is a change to the public API of CordovaLib, so can't get merged until v7.0.0

@dpogue dpogue merged commit 2198319 into apache:master Oct 1, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
* refactor: update allow list naming

* chore: improve variable nameing

* chore: update doc url to cordova main docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants