-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(projectFile): drop dependency on underscore #1116
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
- Coverage 74.88% 74.86% -0.02%
==========================================
Files 13 13
Lines 1724 1723 -1
==========================================
- Hits 1291 1290 -1
Misses 433 433
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As for your suggestion, I'm indifferent. Either approach looks like it will do the job and I don't think either is necessary better than the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Rewrote underscore usage in plain JS.
Rewrote underscore usage in plain JS.
Motivation and Context
Drop dependency on underscore. Ref: #1105
Description
Rewrote underscore usage in plain JS.
Testing
Existing tests pass.