Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(projectFile): drop dependency on underscore #1116

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Drop dependency on underscore. Ref: #1105

Description

Rewrote underscore usage in plain JS.

Testing

Existing tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #1116 (19f54e3) into master (745367f) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   74.88%   74.86%   -0.02%     
==========================================
  Files          13       13              
  Lines        1724     1723       -1     
==========================================
- Hits         1291     1290       -1     
  Misses        433      433              
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/projectFile.js 94.91% <50.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745367f...19f54e3. Read the comment docs.

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As for your suggestion, I'm indifferent. Either approach looks like it will do the job and I don't think either is necessary better than the other.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@raphinesse raphinesse added this to the 6.2.1 milestone Jun 8, 2021
@raphinesse raphinesse merged commit 8a6569c into apache:master Jun 8, 2021
@raphinesse raphinesse deleted the drop-underscore branch June 8, 2021 08:34
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
u01jmg3 pushed a commit to uofa/cordova-ios that referenced this pull request Dec 3, 2022
@NiklasMerz NiklasMerz removed this from the 6.2.1 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants