Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swiftpm): Fix up CordovaLib Swift Package #1160

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 18, 2021

Platforms affected

iOS

Motivation and Context

When installing the package, Xcode complained about "extra" files (cordova.js, VERSION, and Info.plist) and also that we had both a include/Cordova.h file as well as a include/Cordova/ folder.

Description

  • Moved the public framework Cordova.h header back into the Cordova/ folder where it was previously, so that it won't get detected by Swift Package Manager.
  • Added a list of excluded files to Package.swift so it won't complain about extraneous files

Testing

  • All unit tests pass
  • Added CordovaLib to a new ObjectiveC project using Swift Package Manager with no errors

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1160 (92774ea) into master (f12abcc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1160   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files          13       13           
  Lines        1723     1723           
=======================================
  Hits         1290     1290           
  Misses        433      433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12abcc...92774ea. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit 92e6830 into apache:master Oct 18, 2021
@dpogue dpogue deleted the spm-fixes branch October 18, 2021 05:45
@dpogue dpogue added this to the 7.0.0 milestone Oct 18, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants