fix(spec/create): handle createAndBuild promises #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
fix-spec-create-promises
branch
8 times, most recently
from
56dc451
to
f5f4d79
Compare
raphinesse
force-pushed
the
fix-spec-create-promises
branch
from
f5f4d79
to
0eb6bc2
Compare
dpogue
approved these changes
Nov 3, 2021
erisu
approved these changes
Nov 3, 2021
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests did not wait for the promises of the test operations to resolve. That's why our CI did not fail for #1161 and we needed to fix that PR up in #1173.
This PR makes the tests wait for the build to finish and sets appropriate timeouts. Of course, this will result in longer CI run times.