-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep!(dev): bump eslint w/ corrections #1182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 13 13
Lines 1650 1650
=======================================
Hits 1238 1238
Misses 412 412
Continue to review full report at Codecov.
|
fae22db
to
491a5b0
Compare
.eslintrc.yml
Outdated
@@ -24,3 +24,5 @@ overrides: | |||
|
|||
- files: [cordova-js-src/**/*.js] | |||
extends: '@cordova/eslint-config/browser' | |||
rules: | |||
no-var: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule should be applied directly to @cordova/eslint-config/browser
but in the mean time applied here. Will hope to reoslve this in a later patch release of @cordova/eslint-config
.
1528ae2
to
5dcad36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some commit squashing and added a TODO about the rule exception. Good to merge from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I messed up the lockfile :(
I'll fix that!
5dcad36
to
89a7d92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, all good now
I just remembered that we only enforce ES5 for browser code that lives in So I think we should not disable the Nevertheless this PR is still good to go for me (maybe remove my TODO if you agree with the above). |
* dep!(dev): @cordova/eslint-config@^4.0.0 * style(lint): apply auto corrections * style(lint): apply manual corrections prefer-regex-literals
Motivation and Context
Update Eslint Config with Fixes
Description
@cordova/eslint-config@^4.0.0
Testing
npm t
Checklist