Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(create): further increase timeouts to avoid false negatives #1184

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

raphinesse
Copy link
Contributor

The duration of the create tests seems to be highly variant. Probably influenced by GH Action runner load. This PR increases the timeouts generously to avoid premature test cancellation.

@raphinesse raphinesse added the bug label Nov 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #1184 (6357dfd) into master (896dacb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files          13       13           
  Lines        1650     1650           
=======================================
  Hits         1238     1238           
  Misses        412      412           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896dacb...6357dfd. Read the comment docs.

@raphinesse raphinesse merged commit ea9751b into apache:master Nov 7, 2021
@raphinesse raphinesse deleted the increase-timeouts branch November 7, 2021 09:48
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants