refactor: hide implementations of build & run #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes build and run modules more closed by avoiding to expose internals via the resolved promise value. Both modules' main exports previously returned a promise that resolved to a subrocess spawn result. Now these promises resolve to undefined. The public API methods that return these promises did not document a specific promise return value, just when the promise would resolve or reject. Thus, this change is not breaking.
raphinesse
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 13 13
Lines 1650 1650
=======================================
Hits 1238 1238
Misses 412 412
Continue to review full report at Codecov.
|
erisu
approved these changes
Nov 9, 2021
I'd argue they relied on implementation details. But I'd be totally OK with labeling this change as breaking, since we are targeting a new major anyways. |
|
I am OK with any label, but this should be good to merge in. |
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
This makes build and run modules more closed by avoiding to expose internals via the resolved promise value. Both modules' main exports previously returned a promise that resolved to a subrocess spawn result. Now these promises resolve to undefined. The public API methods that return these promises did not document a specific promise return value, just when the promise would resolve or reject. Thus, this change is not breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes build and run modules more closed by avoiding to expose
internals via the resolved promise value. Both modules' main exports
previously returned a promise that resolved to a subrocess spawn result.
Now these promises resolve to undefined.
The public API methods that return these promises did not document a
specific promise return value, just when the promise would resolve or
reject. Thus, this change is not breaking.