refactor: cleanup create script #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove update_cordova_subproject export - remove updateSubprojectHelp export
fs-extra's copySync creates any missing destination directories
fs-extra's removeSync removes anything and nothing w/out throwing
|
I would actually argue that this change is not actually breaking, since I would not consider the removed module exports public API. |
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 1658 1658
=======================================
Hits 1246 1246
Misses 412 412 Continue to review full report at Codecov.
|
raphinesse
changed the title
erisu
approved these changes
Nov 13, 2021
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
* refactor!(create): make helper functions module-private - remove update_cordova_subproject export - remove updateSubprojectHelp export * refactor(create): cleanup, condense & rename update_cordova_subproject * refactor(create): cleanup copyJsAndCordovaLib * refactor(create): drop unused param of copyJsAndCordovaLib * refactor(create): use loop to copy files in copyJsAndCordovaLib * refactor(create): delete obsolete ensureDirSync in copyJsAndCordovaLib fs-extra's copySync creates any missing destination directories * refactor(create): simplify deletion logic in copyJsAndCordovaLib fs-extra's removeSync removes anything and nothing w/out throwing Co-authored-by: Erisu <erisu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This takes the changes from the first four commits of #1191 and adds a few further simplifications in the affected code areas.
I pulled this out to reduce the scope of said PR and since I already reviewed this part of the changes.
Description
From #1191:
updateSubprojectHelpupdate_cordova_subprojectupdate_cordova_subprojecttoupdateCordovaSubprojectupdateCordovaSubprojectto take in two static arguments:projectXcodePathwhich is the path to project's xcodeprojcordovaLibXcodePathwhich is the path to the CordovaLib's xcodeproj. (Note: it maybe a symbolic link when--linkflag is added when installing platform)AbsParentPathAbsProjectPathrelpathupdateSubprojectHelpNew:
copyJsAndCordovaLibTesting
npm t