refactor(create)!: move apple_* binaries & cleanup copyScripts #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we no longer support the platform-centric process the `apple_*_version` binaries can now be moved into the scripts template directory. That also means the copyScripts method can be radically simplified.
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 1658 1658
=======================================
Hits 1246 1246
Misses 412 412 Continue to review full report at Codecov.
|
erisu
approved these changes
Nov 13, 2021
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
…e#1194) Since we no longer support the platform-centric process, the `apple_*_version` binaries can now be moved into the scripts template directory. That also means the copyScripts method can be radically simplified. Co-authored-by: Erisu <erisu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a replacement for commit daac0c1 from #1191 which is broken in my opinion.
Description
In contrast to the original commit, this moves the binaries to the current script template location
bin/templates/scripts/cordova. This folder and its contents can be restructured and moved in a later PR.Testing
npm t