build: build cordova.js during npm prepare #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 1658 1658
=======================================
Hits 1246 1246
Misses 412 412 Continue to review full report at Codecov.
|
erisu
force-pushed
the
feat/build-cordova-js
branch
from
3dee7f5
to
7cd1320
Compare
raphinesse
reviewed
Nov 16, 2021
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
raphinesse
approved these changes
Nov 16, 2021
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
* build: build cordova.js during npm prepare w/ refactor * chore: apply copySync suggestion * dep: move cordova-js as devDep Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This will build
cordova.jsfrom source using npm'spreparehook.Description
cordova.jsfrom source using npm'spreparehookcordova.jsbefore running Xcode testscordova.jsfiles we hadcordova-js-srcanymore, since support for browserify builds has been discontinued for a while nowTesting
npm tcordova platform addcordova build ioscordova run ios