refactor: do not infer project root from script location #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for better or worse...
That change seems unrelated to the scope of this PR. Moreover, it seems we could delete the whole following conditional as well, since we removed support for the platform-centric workflow.
logPath was "$cordovaPath/console.log" before and had been changed to "$projectPath/console.log". This commit reverts that change.
Not pretty either, but at least the ugliness is more local
raphinesse
approved these changes
Nov 20, 2021
|
The added test mentioned in the PR comment is not here, but that's OK. I take it that you just copied the text from my corresponding android PR? 😁 |
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 75.15% 75.09% -0.07%
==========================================
Files 13 13
Lines 1658 1658
==========================================
- Hits 1246 1245 -1
- Misses 412 413 +1
Continue to review full report at Codecov.
|
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The goal of this PR is to eliminate all areas where our JS library expects to be located inside the project directory.
This is to prepare for a change that will keep the library in
node_modulesand not copy it to the platform project.Description
Basically this passes the project root that has been passed to
Apito all places that need it but do not yet have it.This also extends the E2E tests to check that we do not have to require the Api from the platform project folder.Testing
npm tChecklist