Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move cordova templates #1204

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 22, 2021

Motivation and Context

This PR is to move the cordova templates out of bin directory.

Description

  • Moved bin/templates/scripts/cordova/ to templates/cordova/

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 7.0.0 milestone Nov 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #1204 (578d8a9) into master (07383c1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files          15       15           
  Lines        1761     1761           
=======================================
  Hits         1383     1383           
  Misses        378      378           
Impacted Files Coverage Δ
lib/create.js 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07383c1...578d8a9. Read the comment docs.

@erisu erisu force-pushed the refactor/move-cordova-templates branch from e35377b to 3c8c416 Compare December 1, 2021 03:48
- moved 'bin/templates/scripts/cordova' to 'templates/cordova'
@erisu erisu force-pushed the refactor/move-cordova-templates branch from 3c8c416 to 578d8a9 Compare December 1, 2021 03:51
@erisu erisu marked this pull request as ready for review December 1, 2021 03:52
@erisu erisu merged commit 30954ae into apache:master Dec 1, 2021
@erisu erisu deleted the refactor/move-cordova-templates branch December 1, 2021 04:00
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
- moved 'bin/templates/scripts/cordova' to 'templates/cordova'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants